Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: possible attribute error when adding __ex_id__ #96

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix: possible attribute error when adding __ex_id__ #96

merged 3 commits into from
Apr 24, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 24, 2024 •
edited
Loading

Closes #93

Summary of Changes

  • Treat numpy datatypes as primitive, so they don't get wrapped.
  • Wrap the addition of the __ex_id__ into a try-except block to catch a potential attribute error.

@lars-reimann lars-reimann requested a review from a team as a code owner April 24, 2024 13:38
@lars-reimann lars-reimann linked an issue Apr 24, 2024 that may be closed by this pull request
Runtime error "'numpy.int64' object has no attribute '__ex_id__'" #93
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.64s
✅ PYTHON mypy 2 0 2.34s
✅ PYTHON ruff 2 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0f63b0c) to head (f8779bf).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #96   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          713       717    +4     
=========================================
+ Hits           713       717    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit 7cfc0e2 into main Apr 24, 2024
8 checks passed
@lars-reimann lars-reimann deleted the 93-runtime-error-numpyint64-object-has-no-attribute-__ex_id__ branch April 24, 2024 13:46
lars-reimann pushed a commit that referenced this pull request Apr 24, 2024
@semantic-release-bot
chore(release): 0.13.1 [skip ci]
7b1aff6 
## [0.13.1](v0.13.0...v0.13.1) (2024-04-24)

### Bug Fixes

* possible attribute error when adding `__ex_id__` ([#96](#96)) ([7cfc0e2](7cfc0e2)), closes [#93](#93)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error "'numpy.int64' object has no attribute '__ex_id__'"
1 participant
@lars-reimann